This repository was archived by the owner on Apr 21, 2022. It is now read-only.
Conversation
weizou19
requested review from
andkon,
dchai76,
mikehu,
smusali and
vilyapilya
smusali
approved these changes
Oct 31, 2019
Contributor
smusali
left a comment
smusali
left a comment
There was a problem hiding this comment.
I don't have any objection regarding no-var rule as long as it's updated in everywhere here; so, test job which includes linting confirmed it's all good - that means it's also good to me too.
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.